qa/workunits/cephtool/test.sh: false positive fail on /tmp/obj1. #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -247,7 +247,7 @@ function test_tiering_agent() | |||
| done | |||
| $evicted # assert | |||
| # the object is proxy read and promoted to the cache | |||
| rados -p $slow get obj1 /tmp/obj1 | |||
| rados -p $slow get obj1 $TMPFILE | |||
There was a problem hiding this comment.
how about rados -p $slow get obj1 - > /dev/null since we don't use the result? if we reordered tests at some point $TMPFILE could already exist
robbat2
force-pushed
the
wip-test-cephtool-filenames
branch
from
b23a19e
to
5fd0ecb
Compare
If /tmp/obj1 happened to exist already, and was not writable by the testing user, then this test failed! Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
robbat2
force-pushed
the
wip-test-cephtool-filenames
branch
from
5fd0ecb
to
cd0c13b
Compare
|
Amended |
jdurgin
added a commit
that referenced
this pull request
Dec 7, 2015
qa/workunits/cephtool/test.sh: false positive fail on /tmp/obj1. Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If /tmp/obj1 happened to exist already, and was not writable by the
testing user, then this test failed!
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com