infernalis: osd: call on_new_interval on newly split child PG #6849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must call on_new_interval() on any interval change *and* on the creation of the PG. Currently we call it from PG::init() and PG::start_peering_interval(). However, PG::split_into() did not do so for the child PG, which meant that the new child feature bits were not properly initialized and the bitwise/nibblewise debug bit was not correctly set. That, in turn, could lead to various misbehaviors, the most obvious of which is scrub errors due to the sort order mismatch. Fixes: ceph#13962 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit fb120d7)
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2016
…ild PG Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
assigned 
|
@liewegas does this backport look good to merge ? It passed a run of the infernalis rados suite ( see http://tracker.ceph.com/issues/13750#note-14 for details ), except for rados/singleton-nomsgr/{all/11429.yaml} which also is breaks in various ways on the infernalis branch. Note that all valgrind tests in these suites fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ). The upgrade/infernalis suite also passes ( http://tracker.ceph.com/issues/13750#note-15 ) except for "radosgw-admin -n client.0 user create" errors ( http://tracker.ceph.com/issues/14665 ) which I believe to be unrelated. |
liewegas
added a commit
that referenced
this pull request
Feb 8, 2016
osd: call on_new_interval on newly split child PG Reviewed-by: Sage Weil <sage@redhat.com>
Abhishekvrshny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13979