pybind: Implementation of rados_ioctx_snapshot_rollback #6878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manens
force-pushed
the
pybind_rados_ioctx_snap_rollback
branch
from
e3ccfb8
to
a32d90b
Compare
|
could you add your Signed-off-by to the commit message? it's just in the PR description right now. Use 'git commit --amend -s' to edit the commit message, adding the signed-off-by automatically, then force push with 'git push origin +pybind_rados_ioctx_snap_rollback' |
manens
force-pushed
the
pybind_rados_ioctx_snap_rollback
branch
from
a32d90b
to
64a8f7b
Compare
|
@manens you can ignore the bot failure, it is a temporary network failure. You will get another run after rebasing & repushing. |
manens
force-pushed
the
pybind_rados_ioctx_snap_rollback
branch
from
64a8f7b
to
1e995cb
Compare
| """ | ||
| self.require_ioctx_open() | ||
| ret = run_in_thread(self.librados.rados_ioctx_snap_rollback, | ||
| (self.io, cstr(oid), snap.name)) |
There was a problem hiding this comment.
snap.name is populated as a python string, so we should encode it as a byte string via cstr(snap.name) when passing it to the c function here
manens
force-pushed
the
pybind_rados_ioctx_snap_rollback
branch
from
1e995cb
to
3ac716c
Compare
Signed-off-by: Florent Manens <florent@beezim.fr>
manens
force-pushed
the
pybind_rados_ioctx_snap_rollback
branch
from
3ac716c
to
2b50a75
Compare
jdurgin
added a commit
that referenced
this pull request
Dec 10, 2015
pybind: Implementation of rados_ioctx_snapshot_rollback Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Florent Manens florent@beezim.fr