rbd: fix build with "--without-rbd" #6899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
nice catch :-) |
| @@ -433,9 +433,11 @@ bin_DEBUGPROGRAMS += ceph_test_objectcacher_stress | |||
| ceph_test_cfuse_cache_invalidate_SOURCES = test/test_cfuse_cache_invalidate.cc | |||
| bin_DEBUGPROGRAMS += ceph_test_cfuse_cache_invalidate | |||
|
|
|||
| if WITH_RBD | |||
There was a problem hiding this comment.
seems should match src/common/Makefile.am, and just check for LINUX
There was a problem hiding this comment.
You're right.
branch-predictor
force-pushed
the
bp-fix-no-rbd-build
branch
from
d229df6
to
a2de6eb
Compare
It's not possible to build Ceph configured with "--without-rbd", as tests and FileStore depends on components provided by RBD. This changeset fixes this. Fixes: ceph#14058 Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
branch-predictor
force-pushed
the
bp-fix-no-rbd-build
branch
from
a2de6eb
to
15c840c
Compare
jdurgin
added a commit
that referenced
this pull request
Dec 14, 2015
rbd: fix build with "--without-rbd" Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to build Ceph configured with "--without-rbd", as
tests and FileStore depends on components provided by RBD. This changeset
fixes this.
Fixes: #14058
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com