infernalis: mon: Ceph Pools' MAX AVAIL is 0 if some OSDs' weight is 0 #6907
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In get_rule_avail(), even p->second is 0, it's possible to be used as divisor and quotient is infinity, then is converted to an integer which is negative value. So we should check p->second value before calculation. It fixes BUG ceph#13840. Signed-off-by: Chengyuan Li <chengyli@ebay.com> (cherry picked from commit 18713e6)
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2016
…ome OSDs' weight is 0 Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed a run of the infernalis rados suite ( see http://tracker.ceph.com/issues/13750#note-14 for details ), except for rados/singleton-nomsgr/{all/11429.yaml} which also is breaks in various ways on the infernalis branch. Note that all valgrind tests in these suites fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ). The upgrade/infernalis suite also passes ( http://tracker.ceph.com/issues/13750#note-15 ) except for "radosgw-admin -n client.0 user create" errors ( http://tracker.ceph.com/issues/14665 ) which I believe to be unrelated. |
ghost
assigned
liewegas
added a commit
that referenced
this pull request
Feb 8, 2016
infernalis: Ceph Pools' MAX AVAIL is 0 if some OSDs' weight is 0 Reviewed-by: Sage Weil <sage@redhat.com>
Abhishekvrshny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/13929