Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/encoding/readable.sh: add non-whole type skip #6932

Merged
merged 1 commit into from Dec 16, 2015

Conversation

aiicore
Copy link
Contributor

@aiicore aiicore commented Dec 15, 2015

With this modification there will be possibility to skip only one/few
object/s of particular type, not whole type as it was before.

Before:

  • To skip whole TYPE create file named TYPE in forward_incompat
    directory.

Now:

  • To skip whole TYPE create file or empty directory named TYPE in
    forward_incompat directory.
  • To skip one/few object/s of TYPE create directory named TYPE in
    forward_incompat and put into symbolic links to objects that
    you wantt to skip.

Signed-off-by: Igor Podoski igor.podoski@ts.fujitsu.com

With this modification there will be possibility to skip only one/few
object/s of particular type, not whole type as it was before.

Before:
- To skip whole TYPE create file named TYPE in forward_incompat
directory.

Now:
- To skip whole TYPE create file or empty directory named TYPE in
forward_incompat directory.
- To skip one/few object/s of TYPE create directory named TYPE in
forward_incompat and put into symbolic links to objects that
you wantt to skip.

Signed-off-by: Igor Podoski <igor.podoski@ts.fujitsu.com>
@aiicore
Copy link
Contributor Author

aiicore commented Dec 15, 2015

@Sage, as we spoke - this is related with ceph/ceph-object-corpus#2 After merge I'll add symlinks in ceph-object-corpus istead of deleting files.

@liewegas liewegas self-assigned this Dec 15, 2015
@liewegas liewegas added the tests label Dec 15, 2015
@liewegas
Copy link
Member

@aiicore This looks right to me! Does it work when you blacklist the problematic coll_t objects?

@aiicore
Copy link
Contributor Author

aiicore commented Dec 16, 2015

@liewegas Yes, on my reduce_strings branch when I add symlinks to deprecated objects in ceph-object-corpus, it skips them and I have 0 fails in the readable.sh test. When this will be merged, I'll repush my changes into object-corpus adding symlinks and then original PR - reduce strings should pass the test :)

liewegas added a commit that referenced this pull request Dec 16, 2015
tests: allow object corpus readable test to skip specific incompat instances

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit 4fc4102 into ceph:master Dec 16, 2015
@aiicore aiicore deleted the test_fix branch December 16, 2015 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants