rbd-fuse: implement mv operation #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement mv operation for rbd-fuse to rename image. Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com
ghost
added
|
@wuxiangwei Can you add some validation for the destination image name? It shouldn't be blank and shouldn't contain "/" nor "@" characters. |
add validation for destination image name to avoid image name contains invalid characters, such as "/" and "@". Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com
|
@dillaman i have add validation for destination image name, please take a look. thank you. |
dillaman
changed the title
| int rbdfs_rename(const char *path, const char *destname) | ||
| { | ||
| const char *srcname = NULL; | ||
| const char *extra[] = {" ", "@", "/"}; |
There was a problem hiding this comment.
I don't think there is any restriction for spaces in the image name -- at least the rbd CLI doesn't restrict it.
discard space restriction for destination image name of the mv operation. Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com
|
@dillaman hi, i have remove the restriction for spaces in the image name , please check again, thank you . |
dillaman
pushed a commit
that referenced
this pull request
Dec 21, 2015
rbd-fuse: implement mv operation Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement mv operation for rbd-fuse to rename image.
Signed-off-by: Xiangwei Wu wuxiangwei@h3c.com