tests: flush op work queue prior to destroying MockImageCtx #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ceph#14092 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
| @@ -56,6 +57,7 @@ struct MockImageCtx { | |||
|
|
|||
| ~MockImageCtx() { | |||
| wait_for_async_requests(); | |||
| image_ctx->op_work_queue->drain(); | |||
There was a problem hiding this comment.
do we need to drain aio_work_queue here too, to match ~ImageCtx()?
There was a problem hiding this comment.
Not currently needed for the mock tests -- they have an explicit redirector that punts calls to MockImageCtx::op_work_queue::queue to ImageCtx::op_work_queue::queue. See expect_op_work_queue.
jdurgin
added a commit
that referenced
this pull request
Dec 21, 2015
tests: flush op work queue prior to destroying MockImageCtx Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14092
Signed-off-by: Jason Dillaman dillaman@redhat.com