osd: bluestore: fix bluestore_wal_transaction_t encoding test #7168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas could you take a look at this pull request? it fixes another unit test failure. |
tchaikov
force-pushed
the
wip-fix-bluestore-test
branch
from
27d9fcb
to
2c636f0
Compare
bluestore_wal_transaction_t::seq is encoded/dumped but it is not initialized in its ctor. so set it to 0 in its ctor. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-fix-bluestore-test
branch
from
2c636f0
to
9ee941f
Compare
|
ran ./src/test/encoding/check-generated.sh manually, and it passed. |
| @@ -279,7 +279,7 @@ WRITE_CLASS_ENCODER(bluestore_wal_op_t) | |||
|
|
|||
| /// writeahead-logged transaction | |||
| struct bluestore_wal_transaction_t { | |||
| uint64_t seq; | |||
| uint64_t seq = 0; | |||
There was a problem hiding this comment.
is this a c++11-ism that lets you initialize things this way?
There was a problem hiding this comment.
liewegas
added a commit
that referenced
this pull request
Jan 11, 2016
osd: bluestore: fix bluestore_wal_transaction_t encoding test Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bluestore_wal_transaction_t::seq is encoded/dumped but it is not
initialized in its ctor. so set it to 0 in its ctor.
Signed-off-by: Kefu Chai kchai@redhat.com