osd: use optimized is_zero in object_stat_sum_t.is_zero() #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2016 11:22
We already have a fast implementation of is_zero(memory), we should use it instead of using memcmp with temp struct on stack. This change reduces object_stat_sum_t.is_zero() CPU usage by 35-50%. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
Rmvoe unused function buf_is_zero, if someone misses it, a faster one is available in include/inline_memory.h. Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Jan 18, 2016
osd: use optimized is_zero in object_stat_sum_t.is_zero() Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have a fast implementation of is_zero(memory), we should use
it instead of using memcmp with temp struct on stack. This change reduces
object_stat_sum_t.is_zero() CPU usage by 35-50%.
Remove unused buf_is_zero() while we're at it.
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com