-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon/MDSMonitor: add confirmation to "ceph mds rmfailed" #7248
Conversation
lgtm, but would be nice to have this being tested by the cephtool workunit. |
string confirm; | ||
if (!cmd_getval(g_ceph_context, cmdmap, "confirm", confirm) || | ||
confirm != "--yes-i-really-mean-it") { | ||
ss << "WARNING: this will cause failover mechanism to stop working. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make this message more severe.
Maybe "WARNING: this can make your filesystem inaccessible, use extreme caution!"
While we're making changes we should add the checks and warnings to any other commands which deserve them — like the recently demonstrated setmap command. ;) |
…-fs-testing #7248 Reviewed-by: Joao Eduardo Luis <joao@suse.de> Reviewed-by: Greg Farnum <gfarnum@redhat.com>
…-fs-testing #7248 Reviewed-by: Joao Eduardo Luis <joao@suse.de> Reviewed-by: Greg Farnum <gfarnum@redhat.com>
My testing branch is failing make check with "FAIL: test/pybind/test_ceph_argparse.py", and I presume it's because this PR or #7262 got broken somehow. |
Fixes: ceph#14379 Signed-off-by: Yan, Zheng <zyan@redhat.com>
bluestore_wal_transaction_t /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 differ: byte 60, line 5 **** bluestore_wal_transaction_t test 2 dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode decode dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-3q8FRszW0 differ: byte 61, line 5 **** bluestore_wal_transaction_t test 2 copy dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 copy dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-ptIzfCk06 differ: byte 60, line 5 **** bluestore_wal_transaction_t test 2 copy_ctor dump_json check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 dump_json > /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 copy_ctor dump_json > /tmp/typ-eV5I52Jt8 diff /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 differ: byte 25, line 1 **** bluestore_wal_transaction_t test 2 binary reencode check failed **** ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode export /tmp/typ-ybpvQW9mL ./ceph-dencoder type bluestore_wal_transaction_t select_test 2 encode decode encode export /tmp/typ-eV5I52Jt8 cmp /tmp/typ-ybpvQW9mL /tmp/typ-eV5I52Jt8 the failure of 'make check' should not be related to this change |
I know the bluestore encode failures are unrelated, but there are also failures in ceph_test_argparse around the commands being changed in this and the companion PR. |
ceph_test_argparse failure has already been fixed |
mon/MDSMonitor: add confirmation to "ceph mds rmfailed" Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Fixes: #14379
Signed-off-by: Yan, Zheng zyan@redhat.com