Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - port changes from downstream to upstream (RGW) #7264

Merged
merged 10 commits into from Jan 29, 2016
Merged

Conversation

baruza
Copy link
Contributor

@baruza baruza commented Jan 18, 2016

Port changes from the downstream docs to upstream (RGW installation and RGW quick)

Applied downstream version, need more tuning, (removed references to
components specific to Red Hat Ceph Storage.)

Signed-off-by: Bara Ancincova <bancinco@redhat.com>
Removed all mentions about Red Hat specific steps. Added commands for
Ubuntu

Signed-off-by: Bara Ancincova <bancinco@redhat.com>
Signed-off-by: Bara Ancincova <bancinco@redhat.com>
Signed-off-by: Bara Ancincova <bancinco@redhat.com>
@baruza baruza changed the title Port changes from downstream to upstream )RGW Docs - port changes from downstream to upstream (RGW) Jan 18, 2016
.. note:: To run the Ceph object gateway service, you should have a running
Ceph cluster, the gateway host should have access to storage and public
networks, and SELinux should be in permissive mode in rpm-based distros.
As of `firefly` (v0.80), Ceph Object Gateway is runnig on Civetweb (embedded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: running

@theanalyst
Copy link
Member

Since you are touching most of the rgw docs anyway, could you also add the rgw frontends option in the config-ref as well. (Bug: http://tracker.ceph.com/issues/13670)


Execute::
For Ubuntu, execute::

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly you could say if you use iptables as a firewall, execute, instead of For Ubuntu? (Since other distros may use iptables as firewall as well?)

@theanalyst
Copy link
Member

@baruza Overall looks good.. just add a couple of options I mentioned to config-ref page as well and minor nits. Thanks!

baruza added a commit that referenced this pull request Jan 25, 2016
@baruza
Copy link
Contributor Author

baruza commented Jan 25, 2016

@theanalyst, thank you for the review - I've fixed all the things you mentioned (9b078cf) except for documenting the rgw frontend option in config-ref. Could you advice me to whom I should ask about that? (since I don't know anything about it)

@alfredodeza
Copy link
Contributor

@baruza you have a 'Signed-of-by' in this commit: 7eca3a9

But it should really be: 'Signed-off-by'

@baruza
Copy link
Contributor Author

baruza commented Jan 25, 2016

@alfredodeza oh, sorry my mistake - is it possible to amend already pushed commit? Or how can I fix it?

@theanalyst
Copy link
Member

@baruza It is just a file in the same rgw folder ..ie. config-ref.rst https://github.com/ceph/ceph/blob/master/doc/radosgw/config-ref.rst#ceph-object-gateway-config-reference here just add the option rgw frontend and give the default value, and type etc.

@tchaikov
Copy link
Contributor

oh, sorry my mistake - is it possible to amend already pushed commit? Or how can I fix it?

git commit --amend
git push -f

see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches

Signed-off-by: Bara Ancincova <bancinco@redhat.com>
Signed-off-by: bancinco@redhat.com
Signed-of-by: Bara Ancincova <bancinco@redhat.com>
Signed-off-by: Bara Ancincova <bancinco@redhat.com>
Signed-off-by: Bara Ancincova <bara@redhat.com>
liewegas added a commit that referenced this pull request Jan 29, 2016
doc: rgw: port changes from downstream to upstream

Reviewed-by: Kefu Chai <kchai@redhat.com>
@liewegas liewegas merged commit 11cbe45 into master Jan 29, 2016
@liewegas liewegas deleted the wip-doc-RGW branch January 29, 2016 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants