Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mon:When set pool crush rule should consider the pool size. #7341

Merged
merged 1 commit into from Jan 29, 2016

Conversation

songbaisen
Copy link

Mon: When set pool crush rule should consider the pool size.

Fixes: #14495
Signed-off-by: song baisen song.baisen@zte.com.cn

@liewegas
Copy link
Member

This change looks good, but

  • please always put space after colon in the commit message
  • please fix the whitespace in the patch. see CodingStyle or match the surrounding code (spaces betwee 'if' and '(', for instance)

@songbaisen
Copy link
Author

@liewegas Thanks for your good advice. And now I use vim to modify code,but it can not see the space,only use 'git show --color' can see the different.And do you have any good tools better than vim.

@songbaisen
Copy link
Author

@tchaikov Thank you for your reply.I use reference to save memery.

Fixes: ceph#14495
Signed-off-by: song baisen <song.baisen@zte.com.cn>
liewegas added a commit that referenced this pull request Jan 29, 2016
mon: consider the pool size when setting pool crush rule

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit c5a1455 into ceph:master Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants