Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix bluestore_wal_transaction_t encoding test #7342

Merged
1 commit merged into from Jan 25, 2016

Conversation

tchaikov
Copy link
Contributor

bluestore_wal_op_t::op is encoded/dumped but it is not
initialized in its ctor. so set it to 0 in its ctor. 0 is not an
valid op though, but it helps with debugging and testing.

Signed-off-by: Kefu Chai kchai@redhat.com

bluestore_wal_op_t::op is encoded/dumped but it is not
initialized in its ctor. so set it to 0 in its ctor. 0 is not an
valid op though, but it helps with debugging and testing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov added the tests label Jan 25, 2016
@tchaikov
Copy link
Contributor Author

@liewegas this is a fix similar to 9ee941f

@ghost ghost self-assigned this Jan 25, 2016
@ghost ghost added the bug-fix label Jan 25, 2016
@ghost
Copy link

ghost commented Jan 25, 2016

Reviewed-by: Loic Dachary <ldachary@redhat.com>

as soon as the make check returns on success.

@tchaikov
Copy link
Contributor Author

@dachary it failed in

[ RUN      ] TestInternal.MultipleResize
./librbd/Journal.cc: In function 'void librbd::Journal< <template-parameter-1-1> >::handle_op_event_safe(int, uint64_t, const Future&, Context*) [with ImageCtxT = librbd::ImageCtx; uint64_t = long unsigned int; librbd::Journal< <template-parameter-1-1> >::Future = journal::Future]' thread 7f830e865700 time 2016-01-25 07:41:44.512447
./librbd/Journal.cc: 806: FAILED assert(m_state == STATE_READY || m_state == STATE_STOPPING)
 ceph version 10.0.2-1039-gefdc16d (efdc16d19d2d816668e174b50a9d1ab8fbfa9cb0)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x8b) [0x7f8320ee715b]
 2: (librbd::Journal<librbd::ImageCtx>::handle_op_event_safe(int, unsigned long, journal::Future const&, Context*)+0x293) [0x7f8320bdb183]
 3: (Context::complete(int)+0x9) [0x7f8320b74339]
 4: (journal::FutureImpl::finish_unlock()+0x72) [0x7f8320e1b242]
 5: (journal::FutureImpl::C_ConsistentAck::complete(int)+0x12) [0x7f8320e1bf12]
 6: (Finisher::finisher_thread_entry()+0x206) [0x7f8320ec74f6]
 7: (()+0x7df5) [0x7f8316154df5]
 8: (clone()+0x6d) [0x7f831545f1ad]
 NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.
./test/run-rbd-unit-tests.sh: line 10:  2257 Aborted                 RBD_FEATURES=$i unittest_librbd

ghost pushed a commit that referenced this pull request Jan 25, 2016
os/bluestore: fix bluestore_wal_transaction_t encoding test

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit 211d4b4 into ceph:master Jan 25, 2016
@tchaikov tchaikov deleted the wip-fix-ceph-dencoder branch January 25, 2016 09:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant