Crush:add some safe judgment. #7344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| default: | ||
| return NULL; | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
This doesn't really change anything; just switch return 0 to return NULL.
|
The first assert is good, the others aren't helpful. Can you always put a space after the colon in your commit messages? |
Fixes: ceph#14496 Signed-off-by: song baisen song.baisen@zte.com.cn
|
@liewegas Thanks for your review.I have changed it. |
liewegas
added a commit
that referenced
this pull request
Jan 31, 2016
crush: add safety assert Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crush: add some safe judgment.
Fixes: #14496
Signed-off-by: song baisen song.baisen@zte.com.cn