journal: flush commit position on metadata shutdown #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A crash was observed on JournalTrimmer destroy, which was called by the Journaler after metadata shutdown. JournalTrimmer destructor also calls flush_commit_position, but at that time metadata m_timer is already null and it crushed there. Signed-off-by: Mykola Golub <mgolub@mirantis.com>
jdurgin
added a commit
that referenced
this pull request
Jan 27, 2016
journal: flush commit position on metadata shutdown Reviewed-by: Josh Durgin <jdurgin@redhat.com> Reviewed-by: Jason Dillaman <dillaman@redhat.com>
vuhuong
pushed a commit
to vuhuong/ceph-upstream
that referenced
this pull request
Jan 27, 2016
The previous calculation was based upon the image's object size. Since the cache stores smaller bufferheads, the object size is not a good indicator of cache usage and was resulting in objects being evicted from the cache too often. Instead, base the max number of objects on the memory load required to store the extra metadata for the objects. Fixes: ceph#7385 Backport: firefly, hammer Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 0b37894) Conflicts: src/librbd/ImageCtx.cc because hammer has cct->_conf->rbd_cache_size instead of cache_size
steveftaylor
pushed a commit
to steveftaylor/ceph
that referenced
this pull request
May 4, 2016
The previous calculation was based upon the image's object size. Since the cache stores smaller bufferheads, the object size is not a good indicator of cache usage and was resulting in objects being evicted from the cache too often. Instead, base the max number of objects on the memory load required to store the extra metadata for the objects. Fixes: ceph#7385 Backport: firefly, hammer Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 0b37894) Conflicts: src/librbd/ImageCtx.cc because firefly has cct->_conf->rbd_cache_size instead of cache_size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A crash was observed on JournalTrimmer destroy, which was called
by the Journaler after metadata shutdown. JournalTrimmer destructor
also calls flush_commit_position, but at that time metadata m_timer
is already null and it crushed there.
Signed-off-by: Mykola Golub mgolub@mirantis.com