fix the autotools and cmake build (the new fusestore needs libfuse) #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-cmake
branch
3 times, most recently
from
dd3eeb4
to
0f91ba9
Compare
tchaikov
changed the title
as we've basically removed all the HyperTable code. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
Autotools part works for me regardless of whether --without-fuse is used or not. Reviewed-by: Piotr Dałek piotr.dalek@ts.fujitsu.com |
|
@cbodley could you help review the cmake changes? @branch-predictor has helped review, and tested the autotools changes. @liewegas does this make sense to disable fusestore if libfuse-dev/fuse-devel is not installed? |
* use ${FUSE_LIBRARIES} instead of "fuse" when referencing libfuse.
* do not compile FuseStore.cc if !HAVE_LIBFUSE.
* CMakeLists.txt: s/HAVE_FUSE/HAVE_LIBFUSE/, to match with the one
defined for config.h.in.cmake, otherwise we need two vars:
HAVE_LIBFUSE, and HAVE_FUSE
Signed-off-by: Kefu Chai <kchai@redhat.com>
* configure.ac: "#define HAVE_LIBFUSE" if libfuse is found * os/Makefile.am: do not compile FuseStore.cc if libfuse is not found Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@cbodley as we discussed over irc, i dropped the change to |
|
@tchaikov Yeah this makes sense. Sorry I missed this! |
|
@tchaikov thanks. looks good on the cmake side 👍 |
tchaikov
added a commit
that referenced
this pull request
Jan 28, 2016
fix the autotools and cmake build (the new fusestore needs libfuse) Reviewed-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com> Reviewed-by: Casey Bodley <cbodley@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.