build: kill warnings #7397
Merged
build: kill warnings #7397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badone i am fixing the warning we discussed just now here. |
|
needs rebase |
Signed-off-by: Kefu Chai <kchai@redhat.com>
the CollectionHandle variant methods are hidden by the subclasses who do not override it. so the compiler complains. by adding "using" statement we expose them again. Signed-off-by: Kefu Chai <kchai@redhat.com>
fixes the `"HAVE_EXECINFO_H" redefined` warning Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-kill-warnings
branch
3 times, most recently
from
ef47a58
to
4804261
Compare
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-kill-warnings
branch
from
4804261
to
ef94d68
Compare
use ${MAKE} so the make command can be properly propagated to their
children
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-kill-warnings
branch
from
ef94d68
to
e7bdf1c
Compare
|
with this change and ceph/civetweb#8, we will be closer to a green build in master. |
|
@liewegas rebased and added more fixes. |
* and mark the WorkQueue::_process(T *, TPHandle&) a pure virtual method. so we must override it * and mark all override methods with the "override" specifier. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-kill-warnings
branch
from
b9ec3c3
to
e9872ad
Compare
|
@cbodley could you help review the cmake bits in this pr? as @yehudasa gave his blessing to the civetweb change at ceph/civetweb#8, so i assume the submodule change is good. |
|
i also pushed the branch to gitbuilder, see http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-tarball-trusty-amd64-cmake/#origin/wip-kill-warnings . it's green now. |
liewegas
added a commit
that referenced
this pull request
Feb 1, 2016
build: kill warnings Reviewed-by: Sage Weil <sage@redhat.com>
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.