mon: PG Monitor should report waiting for backfill #7398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2061,7 +2061,7 @@ void PGMonitor::get_health(list<pair<health_status_t,string> >& summary, | |||
| if (p->first & PG_STATE_INCOMPLETE) | |||
| note["incomplete"] += p->second; | |||
| if (p->first & PG_STATE_BACKFILL_WAIT) | |||
| note["backfill"] += p->second; | |||
| note["waiting for backfill"] += p->second; | |||
There was a problem hiding this comment.
should be "backfill-wait" instead? to be consistent with the document.
or, we should be consistent with the naming of "foo_wait", just like "recovery_wait". so we should update both the doc and the code:
- s/backfill-wait/backfill_wait/ in doc
- s/"backfill"/"backfill_wait"/ in the line above
There was a problem hiding this comment.
I guess I'll change to backfill_wait here and the doc as well..
|
@tchaikov updated |
|
lgtm modulo the typo in commit message. |
Instead of backfill as it is actually waiting for backfill instead of actually backfilling Fixes: ceph#12744 Reported-by: Dan Mick <dmick@redhat.com> Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Since the state reported is `backfilling` and `backfill_wait` Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
|
Updated again. Thanks for the patient reviews |
|
lgtm |
liewegas
added a commit
that referenced
this pull request
Feb 4, 2016
mon: PG Monitor should report waiting for backfill Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of backfill (as the state is
wait_backfill)Fixes: #12744