Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: remove duplicated code in RGWRados::get_bucket_info() #7413

Merged
merged 1 commit into from Feb 10, 2016
Merged

rgw: remove duplicated code in RGWRados::get_bucket_info() #7413

merged 1 commit into from Feb 10, 2016

Conversation

YankunLi
Copy link
Contributor

The effect of line 7664-7665 is the same as the line 7658-7660

Signed-off-by: liyankun lioveni99@gmail.com

@tchaikov
Copy link
Contributor

@YankunLi

could you update the title of your commit message accordingly? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches

@YankunLi
Copy link
Contributor Author

@tchaikov
sorry,I don't know what you mean.

@tchaikov
Copy link
Contributor

@YankunLi sorry, i meant your commit message now looks like:

delete the redundant code
The effect of line 7664-7665 is the same as the line 7658-7660

Signed-off-by: liyankun <lioveni99@gmail.com>

i'd suggest you to revise it so it would look like

rgw: remove duplicated code in RGWRados::get_bucket_info()

The effect of line 7664-7665 is the same as the line 7658-7660

Signed-off-by: liyankun <lioveni99@gmail.com>

The effect of line 7664-7665 is the same as the line 7658-7660

Signed-off-by: liyankun <lioveni99@gmail.com>
yehudasa added a commit that referenced this pull request Feb 10, 2016
rgw: remove duplicated code in RGWRados::get_bucket_info()

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
@yehudasa yehudasa merged commit da554ae into ceph:master Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants