infernalis: rbd: TaskFinisher::cancel should remove event from SafeTimer #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When canceling scheduled tasks using the timer thread, TaskFinisher::cancel does not call SafeTimer::cancel_event, so events fire anyway. Add this call. Fixes: ceph#14476 Signed-off-by: Douglas Fuller <dfuller@redhat.com> (cherry picked from commit 2aa0f31)
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2016
…d remove event from SafeTimer Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
assigned 
|
@dillaman does this backport look good to merge ? It passed a run of the infernalis rbd suite ( see http://tracker.ceph.com/issues/13750#note-18 for details ). Note that all valgrind tests in this suite fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ). |
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2016
infernalis: rbd: TaskFinisher::cancel should remove event from SafeTimer Reviewed-by: Jason Dillaman <dillaman@redhat.com>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14552