infernalis: librbd: flattening an rbd image with active IO can lead to hang #7484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdurgin requesting review |
dillaman
force-pushed
the
wip-14610-infernalis
branch
2 times, most recently
from
9661a17
to
3b4a5f9
Compare
|
lgtm after a qa run |
ghost
pushed a commit
that referenced
this pull request
Feb 8, 2016
… IO can lead to hang Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
changed the title
|
@dillaman could you please amend the commit of "test: new librbd flatten test case" to shortly explain why it cannot be cherry-picked and has to be applied in this way to the infernalis branch ? For the record: It passed a run of the infernalis rbd suite ( see http://tracker.ceph.com/issues/13750#note-18 for details ). Note that all valgrind tests in this suite fail because of an environmental problem ( http://tracker.ceph.com/issues/14664 ). |
added 4 commits
February 11, 2016 10:01
AIO operations after a flatten operation were previously hanging during the close of the parent image. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 5b3a4d2)
If another (independent) queue was processing, drain could block waiting. Instead, allow drain to exit quickly if no items are being processed and the queue is empty for the current WQ. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit b118d7d)
Add a new convenience method to ImageCtx for handling flush requests and cleanup flush handling with dealing with the cache. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (based on commit ee7c6f7)
Fixes: ceph#14092 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 98157ab)
dillaman
force-pushed
the
wip-14610-infernalis
branch
from
3b4a5f9
to
b0c9176
Compare
dillaman
changed the title
ghost
pushed a commit
that referenced
this pull request
Feb 11, 2016
librbd: flattening an rbd image with active IO can lead to hang Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
merged commit 
Abhishekvrshny
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14610