Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: unregister command on shutdown #7504

Merged
merged 1 commit into from Feb 9, 2016
Merged

mon: unregister command on shutdown #7504

merged 1 commit into from Feb 9, 2016

Conversation

renhwztetecs
Copy link
Contributor

unregister command on shutdown
include: "quorum enter" && "quorum exit"

Signed-off-by: huanwen ren ren.huanwen@zte.com.cn

@xiexingguo
Copy link
Member

So hard working you are:-)

@songbaisen
Copy link

It is really work hard.

@jecluis
Copy link
Member

jecluis commented Feb 3, 2016

@renhwztetecs changes look fine.

Let me nit pick the commit message though. It would be great if you could adjust it to be a bit more comprehensible. Instead of mon:lack of unregister of object in shutdown(), something like mon: Monitor: unregister command on shutdown would be perfect.

@renhwztetecs renhwztetecs changed the title mon:lack of unregister of object in shutdown() mon:Monitor:unregister command on shutdown Feb 4, 2016
@renhwztetecs
Copy link
Contributor Author

@jecluis
hmm,before the description is more redundant, I change it
Thanks a lot for your advice

@liewegas
Copy link
Member

liewegas commented Feb 4, 2016

More nit picking:

  • there is always a space after a colon
  • mon: Monitor: is redundant... just "mon: unregister command on shutdown" is sufficient

@renhwztetecs renhwztetecs changed the title mon:Monitor:unregister command on shutdown mon: Monitor:unregister command on shutdown Feb 5, 2016
@renhwztetecs renhwztetecs changed the title mon: Monitor:unregister command on shutdown mon: unregister command on shutdown Feb 5, 2016
@renhwztetecs
Copy link
Contributor Author

@liewegas
after you remind, I noticed the colon need a space.
Thank you for your careful guidance, I have changed it

unregister command on shutdown
include: "quorum enter" && "quorum exit"

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
liewegas added a commit that referenced this pull request Feb 9, 2016
mon: unregister command on shutdown

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
@liewegas liewegas merged commit a710dcd into ceph:master Feb 9, 2016
@renhwztetecs renhwztetecs deleted the renhw-wip-mon-shutdown branch February 16, 2016 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants