Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix the build of tests #7523

Merged
merged 4 commits into from Feb 11, 2016
Merged

cmake: fix the build of tests #7523

merged 4 commits into from Feb 11, 2016

Commits on Feb 10, 2016

  1. Revert "cmake: add libboost_system to EXTRALIBS" 

    This reverts commit 21438a6.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    aef2006 View commit details
    Browse the repository at this point in the history

  2. cmake: disable warnings introduced by 457f023 

    Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    ef1573b View commit details
    Browse the repository at this point in the history

  3. log: remove "boost/asio.hpp" from Log.h 

    graylog uses boost/asio.hpp which introduces the link-time dependency on
libboost_system to the compilation units which includes Log.h and
LogClient.h. so it appears that perfglue/heap_profiler.cc is referencing
libboost_system.so, and fails the cmake build of all tests which links
against tcmalloc.

in this change, we:

* remove unnecessary #includes from Graylog.h
* forward declare Graylog class, so that "Graylog.h" is not included in
  any header files to avoid the link-time dependency pollution

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    f5cad7a View commit details
    Browse the repository at this point in the history

  4. cmake: remove Boost libraries from EXTRALIBS 

    * and remove ${Boost_SYSTEM_LIBRARY} from test_rados_api_tier

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Feb 10, 2016
    Configuration menu
    Copy the full SHA
    075e595 View commit details
    Browse the repository at this point in the history