OSD/ReplicatedPG: Fixes unneccessary object promotion when deleting f… #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pool.info.min_write_recency_for_promote, | ||
| OpRequestRef(), | ||
| promote_obc); | ||
| promote_obc)) { | ||
| return cache_result_t::BLOCKED_PROMOTE; |
There was a problem hiding this comment.
This hunk looks like an unrelated bug fix.. can you move it into a separate patch?
|
can you also move the cleanup into a separate patch? Thanks! |
…rom the cache that lacks hit_set configured. Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
ifed01
force-pushed
the
wip-no-promote-for-delete-fix
branch
from
658ecbc
to
12c083e
Compare
|
@liewegas, fixed. |
liewegas
added a commit
that referenced
this pull request
Feb 11, 2016
osd: fix unnecessary object promotion when deleting from cache pool Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rom the cache that lacks hit_set configured.
Minor cleanup nearby too.
This issue was mentioned at http://tracker.ceph.com/issues/13894 ( comment #12 and beyond ) but it's probably not the root cause of 13894.
Signed-off-by: Igor Fedotov ifedotov@mirantis.com