common/bit_vector: use hard-coded value for block size #7610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the test failing, which I guess is dumb, can you add the issue I filed after you filed this PR to the commit msg (i.e. Fixes: #14747) so it links up with tracker? |
The CEPH_PAGE_SIZE is not actually a constant. On aarch64 platforms the page size is 64K instead of the assumed 4K. The CRC block computations require a true constant. Fixes: ceph#14747 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-bit-vector
branch
from
cd76eac
to
ba2e6ce
Compare
|
done |
dmick
added a commit
that referenced
this pull request
Feb 16, 2016
common/bit_vector: use hard-coded value for block size Reviewed-by: Dan Mick <dmick@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CEPH_PAGE_SIZE is not actually a constant. On arm64 platforms
the page size is 64K instead of the assumed 4K. The CRC block
computations require a true constant.
Signed-off-by: Jason Dillaman dillaman@redhat.com