osd: consider high/low mode when putting agent to sleep #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we are in low flush mode, we may only get up to max_low_ops in flight, in which case we may never go to sleep here. Fix it by using the max_low_ops threshold when appropriate. Note that agent_work() might start up *more* than this many ops (if there are lots of evicts to do) currently, but I think it is fine if evicts go a bit slower if we are in low mode. (Really, the high/low shouldn't be tied to flushing specifically.) Fixes: ceph#14752 Reported-by: Markus Blank-Burian <burian@muenster.de> Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-agent-flush-low
branch
from
fc8f195
to
613457f
Compare
|
passed rados suite |
athanatos
added a commit
that referenced
this pull request
Mar 15, 2016
osd: consider high/low mode when putting agent to sleep Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are in low flush mode, we may only get up to max_low_ops in flight,
in which case we may never go to sleep here.
Fix it by using the max_low_ops threshold when appropriate.
Note that agent_work() might start up more than this many ops (if there
are lots of evicts to do) currently, but I think it is fine if evicts go
a bit slower if we are in low mode. (Really, the high/low shouldn't be
tied to flushing specifically.)
Reported-by: Markus Blank-Burian burian@muenster.de
Signed-off-by: Sage Weil sage@redhat.com