Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librados: implement async watch/unwatch #7649

Merged
merged 11 commits into from Feb 24, 2016
Merged

librados: implement async watch/unwatch #7649

merged 11 commits into from Feb 24, 2016

Conversation

yuyuyu101
Copy link
Member

No description provided.

@yuyuyu101 yuyuyu101 force-pushed the wip-async-watch branch 5 times, most recently from 596bc23 to 986a2c9 Compare February 16, 2016 03:33
@yuyuyu101
Copy link
Member Author

done

@yuyuyu101
Copy link
Member Author

retest this please

@jdurgin jdurgin mentioned this pull request Feb 17, 2016
Merged
@dillaman
Copy link

@yuyuyu101 Can you also add an async version of Rados::watch_flush?

@yuyuyu101
Copy link
Member Author

@dillaman sure

@yuyuyu101 yuyuyu101 force-pushed the wip-async-watch branch 3 times, most recently from e149680 to 5ec9015 Compare February 19, 2016 04:14
@dillaman dillaman self-assigned this Feb 19, 2016
@yuyuyu101
librados: add async watch api
87e715c 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
librados: add unittest for rados aio watch
569b121 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
librados: support aio_unwatch api
28ac263 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
test: add aio_unwatch unittest
2be574a 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
librados: remove unused variables
f04c96c 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
librados: add C api impl and tracing codes
f977f0a 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
Copy link
Member Author

@dillaman done

@yuyuyu101
Objecter: make linger_callback_flush accept context instead of blocking
f5d8da6 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
RadosClient: add async watch_flush version
b651dd7 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
librados: add async_watch_flush api
afdc3cc 
Signed-off-by: Haomai Wang <haomai@xsky.com>
dillaman
dillaman reviewed Feb 21, 2016
View reviewed changes
src/test/librados/watch_notify.cc

rados_completion_t comp;
ASSERT_EQ(0, rados_aio_create_completion(NULL, NULL, NULL, &comp));
rados_async_watch_flush(cluster, comp);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't build -- should be rados_aio_watch_flush

@yuyuyu101
test_rados_watch_notify: add async_watch_flush tests
ad44b5e 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
Copy link
Member Author

done

@dillaman
Copy link

I had this branch merged into wip-jd-testing for a teuthology run: http://pulpito.ceph.com/jdillaman-2016-02-22_09:18:56-rbd-wip-jd-testing---basic-multi/

It appears all clients are locking up on the sync watch_flush call:

[ubuntu@smithi001 ~]$ ceph osd crush tunables default
2016-02-22 17:47:58.631634 7efcce041700 1 librados: starting msgr at :/0
2016-02-22 17:47:58.631645 7efcce041700 1 librados: starting objecter
2016-02-22 17:47:58.631919 7efcce041700 1 librados: setting wanted keys
2016-02-22 17:47:58.631923 7efcce041700 1 librados: calling monclient init
2016-02-22 17:47:58.635064 7efcce041700 1 librados: init done
adjusted tunables profile to default
2016-02-22 17:47:58.919154 7efcce041700 10 librados: watch_flush enter

I assume it is because the finisher was already stopped on shut down prior to invoking watch_flush.

@yuyuyu101
Copy link
Member Author

@dillaman I agree with your point. But I don't find anywhere we call watch_flush after objecter shutdown

@dillaman
Copy link

https://github.com/yuyuyu101/ceph/blob/wip-async-watch/src/librados/RadosClient.cc#L334
https://github.com/yuyuyu101/ceph/blob/wip-async-watch/src/librados/RadosClient.cc#L346

@yuyuyu101
Copy link
Member Author

oh, sorry. I got it

@yuyuyu101
Copy link
Member Author

done

@yuyuyu101
RadosClient: call watch_flush before finisher stop
7109de7 
Signed-off-by: Haomai Wang <haomai@xsky.com>
@yuyuyu101
Copy link
Member Author

done

dillaman pushed a commit that referenced this pull request Feb 24, 2016
Merge pull request #7649 from yuyuyu101/wip-async-watch
dc5a905 
librados: implement async watch/unwatch

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
@dillaman dillaman merged commit dc5a905 into ceph:master Feb 24, 2016
@yuyuyu101 yuyuyu101 deleted the wip-async-watch branch February 24, 2016 05:14
@yuyuyu101 yuyuyu101 restored the wip-async-watch branch February 24, 2016 09:29
@yuyuyu101 yuyuyu101 deleted the wip-async-watch branch February 24, 2016 13:36
athanatos added a commit to athanatos/ceph that referenced this pull request Feb 26, 2016
@athanatos
Revert "Merge pull request ceph#7649 from yuyuyu101/wip-async-watch"
0337124 
This reverts commit dc5a905, reversing
changes made to 0b56c5e.

Conflicts:
	src/librados/IoCtxImpl.cc
	src/osdc/Objecter.cc
@xiaoxichen xiaoxichen mentioned this pull request Sep 9, 2016
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 13, 2021
Open
@ekmixon ekmixon mentioned this pull request Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dillaman dillaman

Labels
core feature
Projects
None yet
Milestone
No milestone
2 participants
@yuyuyu101 @dillaman