[cephfs] fix free fds being exhausted eventually because freed fds are never put back #7685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e never put back Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
|
good catch. |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 8, 2016
…eph into greg-fs-testing #7685 Reviewed-by: Yan, Zheng <zyan@redhat.com>
|
http://qa-proxy.ceph.com/teuthology/gregf-2016-03-07_23:12:27-fs-greg-fs-testing-3-7-safe---basic-mira/ |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 10, 2016
[cephfs] fix free fds being exhausted eventually because freed fds are never put back Reviewed-by: Yan, Zheng <zyan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open and create operation in libcephfs will get a free fd from the free_fd_set. This free fd will be erased from the free_fd_set. But in close operation, it just erases this free fd from fd_map and never put it back to free_fd_set. So free_fd_set will exhaust all the free fds initialized at beginning eventually. I think we should put freed fd back to free_fd_set for reusing.
Fixes: #14798
Signed-off-by: Zhi Zhang zhangz.david@outlook.com