pybind: rados cleanup #7692
Merged
pybind: rados cleanup #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sileht
force-pushed
the
sileht/rados-cython
branch
from
981f28f
to
b32c4cf
Compare
This change uses: * a pystring to store ioctx state like other state attributes and like previous binding * use __dealloc__ instead of __del__ to ensure Object are freed correctly Signed-off-by: Mehdi Abaakouk <sileht@redhat.com>
sileht
force-pushed
the
sileht/rados-cython
branch
from
b32c4cf
to
0fb387f
Compare
|
Good catch, this makes me think we should get rid of next() as well: http://docs.cython.org/src/userguide/special_methods.html#the-next-method |
jdurgin
added a commit
that referenced
this pull request
Feb 19, 2016
pybind/rados: use __dealloc__ since __del__ is ignored by cython Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses:
previous binding