Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon/pgmonitor: use appropriate forced conversions in get_rule_avail #7705

Merged
merged 1 commit into from Mar 7, 2016
Merged

mon/pgmonitor: use appropriate forced conversions in get_rule_avail #7705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mon/PGMonitor.cc
View file
Open in desktop
Expand Up @@ -1394,8 +1394,8 @@ int64_t PGMonitor::get_rule_avail(OSDMap& osdmap, int ruleno) const
// calculate proj below.
continue;
}
int64_t proj = (float)((osd_info->second).kb_avail * 1024ull) /
(double)p->second;
int64_t proj = (int64_t)((double)((osd_info->second).kb_avail * 1024ull) /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why shall we add "double" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov
Not necessary, just in order to better identify

(double)p->second);
if (min < 0 || proj < min)
min = proj;
} else {
Expand Down