Wip filelock deadlock #7713
Merged
Wip filelock deadlock #7713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>
ukernel
force-pushed
the
wip-filelock-deadlock
branch
from
6ea9a1c
to
7987e54
Compare
|
@jcsp, please review |
| return l.client > r.client ? 1 : -1; | ||
| if (l.owner != r.owner) | ||
| return l.owner > r.owner ? 1 : -1; | ||
| if (l.owner & (1ULL << 63)) |
There was a problem hiding this comment.
It would be good to have a descriptive-named #define for this 1<<63 mask
There was a problem hiding this comment.
Or just copy the comment from ceph_filelock_owner_equal up above; it confused the heck out of me until I looked at the full file and saw that. :)
|
This looks sane to me, I'm inclined to merge once tests are run, I've included this on just-pushed-to-gitbuilders wip-jcsp-testing branch |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 14, 2016
… into greg-fs-testing #7713 Reviewed-by: John Spray <john.spray@redhat.com>
|
Reviewed-by |
|
sounds good, it's passed through my branch as well |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 15, 2016
Wip filelock deadlock Reviewed-by: John Spray <john.spray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.