journal: improve commit position tracking #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 26, 2016 11:50
librbd should treat the corruption of the journal differently from missing journal entries. If entries are missing, it might be the result of a crash and the journal should just be replayed through the most recent, consistent entry. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
It's possible, when delaying appends to the journal, that the current commit position might be in object set X while future events for a different offset might be in an object set < X. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Prevent async reload from canceling out an in-flight update. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-librbd-journal-tweaks
branch
from
bbd55f2
to
41e5422
Compare
|
lgtm |
jdurgin
added a commit
that referenced
this pull request
Mar 2, 2016
journal: improve commit position tracking Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if batched appends were enabled, it was possible for uncommitted entries to not be replayed because the prefetch started in a later object set.