hammer: ceph init script unconditionally sources /lib/lsb/init-functions #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
ghost
pushed a commit
that referenced
this pull request
Feb 26, 2016
…urces /lib/lsb/init-functions Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
this passed a run of the upgrade suite ( http://tracker.ceph.com/issues/14692#note-29 ) but make check failed (the logs are gone though). @smithfarm could you please rebase & repush to get a another run ? |
On OSX/FreeBSD, /lib/lsb/init-functions does not exist Signed-off-by: Yan, Zheng <zyan@redhat.com> (cherry picked from commit bb1fa7f)
smithfarm
force-pushed
the
wip-14861-hammer
branch
from
d4434f3
to
e014ea8
Compare
ghost
pushed a commit
that referenced
this pull request
Mar 4, 2016
…urces /lib/lsb/init-functions Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Mar 4, 2016
hammer: ceph init script unconditionally sources /lib/lsb/init-functions Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/14861