Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: packaging fixes for jewel #7807

Merged
merged 4 commits into from Feb 26, 2016
Merged

debian: packaging fixes for jewel #7807

merged 4 commits into from Feb 26, 2016

Conversation

ktdreyer
Copy link
Member

Fixes the Trusty build failure in Gitbuilder.

SUSE does not allow the use of /usr/libexec, so commit
69291f8 changed the RPM
packaging to put the libexec files into /usr/lib instead. Do the same
thing on Debian.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Fixes a failure to build from source; fallout from the server split
change (0cbe3de)

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
@ktdreyer
Copy link
Member Author

CC'ing @smithfarm @javacruft @alimaredia in case they want to review.

@ktdreyer ktdreyer added this to the jewel milestone Feb 25, 2016
@@ -67,7 +67,7 @@ clean:
ltmain.sh missing
rm -f configure Makefile.in man/Makefile.in src/Makefile.in
rm -f src/acconfig.h.in
rm -f debian/ceph-base.init debian/radosgw.init debian/ceph-base/etc/logrotate.d/ceph.logrotate debian/radosgw.logrotate
rm -f debian/ceph-base.init debian/radosgw.init debian/ceph.logrotate debian/radosgw.logrotate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change and the change above it undo the changes I made before merged, does ceph.logrotate not belong in debian/ceph-base/etc/logrotate.d/ anymore? Or did the changes I made not accomplish that? I remember it was a little tricky getting the logrotate files where I wanted them when I was making changes on them in November

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess we'd gotten it wrong in the earlier commit (0cbe3de) - sorry for leading you astray!

@smithfarm
Copy link
Contributor

My Debian packaging skills are quite rusty. With that caveat:

Reviewed-by: Nathan Cutler <ncutler@suse.com>

@ktdreyer
Copy link
Member Author

Re-pushed with packaging the libceph compressor files in the ceph-common .deb instead of the ceph-base .rpm (from Sage, "Re: packaging compressor plugins" thread on ceph-devel today.)

@tchaikov
Copy link
Contributor

@alimaredia and @ktdreyer i've some nit at 0cbe3de if they make sense to you guys, can we also address them in this pull request?

ktdreyer referenced this pull request Feb 26, 2016
Split up the "ceph" package into four new packages:

  1. ceph-mon
  2. ceph-osd
  3. ceph-mds (already done on Debian)
  4. ceph-base (files shared among multiple servers)

and then:

  5. Make "ceph" into a metapackage that depends on both -mon and -osd
    (and -mds, for RPMs).

To describe the outcome of this change another way:

  For RPMs:
  - "ceph-{mon,osd,mds}" Require: ceph-base.
  - "ceph" will become a metapackage that Requires: ceph-{mon,osd,mds}.

  For DEBs:
  - "ceph-{mon,osd,mds}" will Depends: ceph-base.
  - "ceph" will become a metapackage that Depends: ceph-{mon,osd}.
  - "ceph" will continue to Recommends: ceph-mds

New users should "yum install ceph-mon" or "yum install ceph-osd" (or
"apt-get install ceph-mon", etc) in order to install the exact daemons
that they need.

http://tracker.ceph.com/issues/10587 Fixes: #10587

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
@ktdreyer
Copy link
Member Author

Thanks Kefu, I've added the fix for ceph-base's dependencies.

The ceph-base package contains files shared between the -mon, -osd, and
-mds. In other words, the MON, OSD, and MDS servers depend on ceph-base,
but ceph-base should not depend on the leaf packages.

Reported-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
@ktdreyer
Copy link
Member Author

Re-pushed this PR without the compressor plugins. We'll have to handle those some other way. They need to be available to every package (librados2, librbd1, libcephfs1, plus all the daemons).

Signed-off-by: Ali Maredia <amaredia@redhat.com>
@dmick dmick self-assigned this Feb 26, 2016
dmick added a commit that referenced this pull request Feb 26, 2016
debian: packaging fixes for jewel

Reviewed-by: Dan Mick <dmick@redhat.com>
@dmick dmick merged commit a710dcc into jewel Feb 26, 2016
@dmick dmick deleted the wip-debian-fixes branch February 26, 2016 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants