rgw: fixes for per-period metadata logs #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
force-pushed
the
wip-rgw-period-meta-logs
branch
from
bafad72
to
af06990
Compare
Signed-off-by: Casey Bodley <cbodley@redhat.com>
now that the shards will be coming and going after startup, they need to be reference counted and protected by a mutex Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
RGWMetadataManager::init() will depend on async_rados Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
RGWMetadataManager::get_log() will allocate a log and keep it in memory. this could lead to a potential denial of service by making requests with lots of different period ids RGWMetadataLog if effectively stateless (the only state is a set of modified_shards, which are not touched by any of the rest api calls), so we can use a temporary instead of calling get_log() Signed-off-by: Casey Bodley <cbodley@redhat.com>
the InitSyncStatus coroutine records the position to start incremental sync after finishing a full sync. this should be the master's marker from the current period, rather than its oldest log period this also adds a check to run_sync() that restarts a full sync if it sees that our sync period is behind the master's oldest log period Signed-off-by: Casey Bodley <cbodley@redhat.com>
the 'int ret' variable of the inner scope was shadowing an 'int ret' variable in the outer scope, so we weren't propagating any of the error codes Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley
force-pushed
the
wip-rgw-period-meta-logs
branch
from
af06990
to
9a6771a
Compare
yehudasa
added a commit
that referenced
this pull request
Mar 5, 2016
rgw: fixes for per-period metadata logs Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set addresses the pending comments from the previously merged #7699. It also finishes implementing
find_oldest_log_period()on the metadata master, and fixes the way the remote side was using it.