rbd: deprecate image format 1 #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,6 +78,9 @@ Context *OpenRequest<I>::handle_v1_detect_header(int *result) { | |||
| } | |||
| send_close_image(*result); | |||
| } else { | |||
| lderr(cct) << "RBD image format 1 is deprecated. " | |||
| << "Please migrate this image to image format 2." << dendl; | |||
There was a problem hiding this comment.
maybe say "copy" instead of "migrate" so there's no confusion about how to do it (this was a common question when format 2 came out)
The rbd cli will warn about the deprecation when attempting to create image format 1 images. librbd will log an error message when opening a format 1 RBD image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Done |
|
lgtm |
jdurgin
added a commit
that referenced
this pull request
Mar 2, 2016
rbd: deprecate image format 1 Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rbd cli will warn about the deprecation when attempting to create
image format 1 images. librbd will log an error message when opening
a format 1 RBD image.
Signed-off-by: Jason Dillaman dillaman@redhat.com