qa/workunits/cephtool/test.sh: wait longer in ceph_watch_start() #7861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"ceph --watch-debug" and "ceph tell mon.foo version" could connect to different monitors, and there is chance that "ceph --watch-debug" is not connected yet when "ceph tell" completes, and hence the former fails to collect the cluster log including the "ceph tell" related message. this renders test_mon_tell() unreliable. so, in ceph_watch_start(), we should wait until the "ceph" cli connects to the monitor and receives messages from it. Fixes: ceph#14910 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
the failed test is not relevant . rebase and repush to try again. |
liewegas
added a commit
that referenced
this pull request
Mar 7, 2016
qa/workunits/cephtool/test.sh: wait longer in ceph_watch_start() Reviewed-by: Sage Weil <sage@redhat.com>
wjwithagen
added a commit
to wjwithagen/ceph
that referenced
this pull request
Mar 8, 2016
Merge pull request ceph#7861 from tchaikov/wip-14910 Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ceph --watch-debug" and "ceph tell mon.foo version" could connect
to different monitors, and there is chance that "ceph --watch-debug"
is not connected yet when "ceph tell" completes, and hence the former
fails to collect the cluster log including the "ceph tell" related
message. this renders test_mon_tell() unreliable. so, in
ceph_watch_start(), we should wait until the "ceph" cli connects to the
monitor and receives messages from it.
Fixes: #14910
Signed-off-by: Kefu Chai kchai@redhat.com