New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libcephfs: fix python tests and fix getcwd on missing dir #7901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2016
@ukernel, please review |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 9, 2016
…greg-fs-testing #7901 Reviewed-by: Yan, Zheng <zyan@redhat.com>
jcsp
force-pushed
the
wip-pycephfs-fixes
branch
2 times, most recently
from
March 10, 2016 13:24
f551b1e
to
25e8e36
Compare
gregsfortytwo
added a commit
that referenced
this pull request
Mar 11, 2016
…greg-fs-testing #7901 Reviewed-by: Yan, Zheng <zyan@redhat.com>
Borrowed this from rados/test_python. It's for invoking the test that lives in src/test/pybind/test_cephfs.py Signed-off-by: John Spray <john.spray@redhat.com>
This was passing 0 for mode on all opened files, resulting in subsequent calls failing because the files didn't have the right permission bits. Did this ever work? Perhaps if the client was laxer in check before? Signed-off-by: John Spray <john.spray@redhat.com>
...if the directory has been unlinked in the background. Previously this would assert out, now it will just give you the last string that you passed into chdir. Signed-off-by: John Spray <john.spray@redhat.com>
The python bindings were expecting a different behaviour than libcephfs actually has. On overflow, it doesn't return the data size, it just gives you -ERANGE. The python bindings need to cope with that, and also let you pass in a size param so that you can handle it. Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
force-pushed
the
wip-pycephfs-fixes
branch
from
March 14, 2016 12:33
25e8e36
to
7043b59
Compare
Updated to run tests as root. Nothing rooty about the tests, other than that in teuthology the filesystem's root dir has uid 0, so so does everything that wants to write there. |
Passing here (along with flock change): http://qa-proxy.ceph.com/teuthology/jspray-2016-03-15_08:58:50-fs:basic-wip-pycephfs-flock---basic-mira/62101/teuthology.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.