Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: use delete[] #7904

Merged
merged 2 commits into from Mar 8, 2016
Merged

log: use delete[] #7904

merged 2 commits into from Mar 8, 2016

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Mar 3, 2016

No description provided.

@liewegas
log: use correct delete[]
23f459c 
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
log: fix some whitespace
58250f5 
Signed-off-by: Sage Weil <sage@redhat.com>
@smithfarm
Copy link
Contributor

Since the memory for buf was allocated with operator new[], it must be deallocated with operator delete[]. The whitespace changes look good, too.

Reviewed-by: Nathan Cutler <ncutler@suse.com>

@tchaikov
Copy link
Contributor

tchaikov commented Mar 5, 2016

lgtm. Reviewed-by: Kefu Chai <kchai@redhat.com>

liewegas added a commit that referenced this pull request Mar 8, 2016
@liewegas
Merge pull request #7904 from liewegas/wip-log-delete
bdd2ddb 
log: use delete[]

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
@liewegas liewegas merged commit bdd2ddb into ceph:master Mar 8, 2016
@liewegas liewegas deleted the wip-log-delete branch March 8, 2016 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix core needs-qa wip-sage-testing
Projects
None yet
Milestone
No milestone
3 participants
@liewegas @smithfarm @tchaikov