tools/rados: reduce "rados put" memory usage by op_size #7928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch-predictor
changed the title
|
lgtm. |
indata.append(char*, len) causes buffer "buf" to be physically copied to new memory block. Make static buffer pointing to buf so we don't need any intermediate copies. This reduces memory usage by op_size, and also cpu usage by a bit (no memmove necessary). Signed-off-by: Piotr Dałek <piotr.dalek@ts.fujitsu.com>
branch-predictor
force-pushed
the
bp-radostool-reduce-mem
branch
from
7ef4683
to
5810eb0
Compare
liewegas
added a commit
that referenced
this pull request
Mar 9, 2016
tools/rados: reduce "rados put" memory usage by op_size Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indata.append(char*, len) causes buffer "buf" to be physically copied
to new memory block. Make static buffer pointing to buf so we don't need
any intermediate copies. This reduces memory usage by op_size, and also
cpu usage by a bit (no memmove necessary).
Signed-off-by: Piotr Dałek piotr.dalek@ts.fujitsu.com