test/bufferlist: Avoid false-positive tests #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is using the length of ptr to determine if the string is correct. As 'ptr' is a copy of the original 'str', it sounds safer to compare against the original string size of the consider the actual size of the string : if 'ptr' is shorter than 'str', the actual code will PASS while 'ptr' is broken. This patch offer to use the same testing logic as per "ptr(const ptr& p, unsigned o, unsigned l)" test by using a memcmp against the original string length. Signed-off-by: Erwan Velu <erwan@redhat.com>
ghost
added
|
oh i see! sounds good. |
|
Thx @liewegas |
liewegas
added a commit
that referenced
this pull request
Mar 11, 2016
test/bufferlist: Avoid false-positive tests Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is using the length of ptr to determine if the string is
correct.
As 'ptr' is a copy of the original 'str', it sounds safer to compare against the
original string size of the consider the actual size of the string : if 'ptr' is
shorter than 'str', the actual code will PASS while 'ptr' is broken.
This patch offer to use the same testing logic as per "ptr(const ptr& p,
unsigned o, unsigned l)" test by using a memcmp against the original string
length.
Signed-off-by: Erwan Velu erwan@redhat.com