Wip rgw multisite fixes #8013
Merged
Wip rgw multisite fixes #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A racing object sync can end up with multiple calls to cb.complete() which in turn will end up with this method getting called multiple times. We can't claim the bufferlist again, and will just clobber first_chunk. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Need to shut this thread first, so that async callbacks don't occur when we shut down the data/meta sync processors. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
first stop all sync threads, then delete them. Might be referencing each other. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
completion manager is now refcounted, and keeps track of all the notifiers. This is needed so that when we shut down we can release all completion notifiers, so that they don't reference the manager anymore. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
Merged
oritwas
added a commit
that referenced
this pull request
Mar 11, 2016
rgw multisite fixes Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple fixes that mainly deal with clean shutdown (fixing ordering, refcouting, etc.).