Commits on Mar 10, 2016

1. Packaging: Removing conditional BuildRequires for btrfs-progs …

   By pull request 7742, the btrfs-progs package was considered as a BuildRequires
   only when --with tests was engaged like :
   
       if %{with tests}
       BuildRequires: btrfsprogs
       %endif
   
   That's perfectly valid for a spec file.
   
   The issue we have is the following :
   - yum-builddep called by install-deps.sh is used to prepare the build env by
   installing the needed BuildRequires.
   - %{with test} is defined by using a %bcond_with
   - yum-builddep doesn't consider %{with test} as valid
   - yum-builddep doesn't install the btrfs package
   
   As per discussions with the yum team, there is no way to engage conditional flags with
   yum-builddep.
   
   So this patch, as per discussions with Nathan Cutler & Loic Dachary, is removing
   the condition arond the BuildRequires.
   
   Note that all BuildRequires defined with a %bcond_with would be affected by this
   issue. The current specfile only have %bcond_without conditional BuildRequires
   which is fine.
   
   Fixes: ceph#15042
   Signed-off-by: Erwan Velu <erwan@redhat.com>

   Erwan Velu committed Mar 10, 2016
   Copy the full SHA

   2294c73 View commit details

   Browse the repository at this point in the history