hammer: clock skew report is incorrect by ceph health detail command #8051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jecluis Please review |
|
@xiaoxichen The commits are missing the "(cherry-picked from . . .)" line - this is added automatically which you provide the |
xiaoxichen
changed the title
|
cherry-pick seems not cleanly, will fix it. |
xiaoxichen
changed the title
xiaoxichen
force-pushed
the
wip-15024-hammer
branch
2 times, most recently
from
bc16a2a
to
c8d7761
Compare
xiaoxichen
changed the title
|
@xiaoxichen: Could you add to the first commit message a description of the conflicts and how you resolved them? This if debugging/forensics are necessary later, such descriptions can save a lot of time. |
When in the presence of a clock skew, adjust the checking interval according to how many rounds have gone by since the last clean check. If a skew is detected, instead of waiting an additional 300 seconds we will perform the check more frequently, gradually backing off the frequency if the skew is still in place (up to a maximum of 'mon_timecheck_interval', default: 300s). This will help with transient skews. Signed-off-by: Joao Eduardo Luis <joao@suse.de> (cherry pick from commit 45e16d0) Conflicts: src/common/config_opts.h Merge the change line. src/mon/Monitor.h handle_timecheck_leader(MonOpRequestRef op) was replaced with handle_timecheck_leader(MTimeCheck *m) also for handle_timecheck_peon and handle_timecheck.
By weighting the reports we were making it really hard to get rid of a
clock skew warning once the cause had been fixed.
Instead, as soon as we get a clean bill of health, let's run a new round
and soon as possible and ascertain whether that was a transient fix or
for realsies. That should be better than the alternative of waiting for
an hour or something (for a large enough skew) for the warning to go
away - and with it, the admin's sanity ("WHAT AM I DOING WRONG???").
Fixes: ceph#14175
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
(cherry pick from commit 17d8ff4)
xiaoxichen
force-pushed
the
wip-15024-hammer
branch
from
c8d7761
to
01672b4
Compare
|
@smithfarm see if it works for you. |
ghost
pushed a commit
that referenced
this pull request
Apr 5, 2016
…eph health detail command Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@liewegas does this backport look good to merge ? It passed the hammer upgrade suite ( http://tracker.ceph.com/issues/14692#note-52 ) and the rados suite http://tracker.ceph.com/issues/14692#note-51). |
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/15024