[DNM] rbd-mirror: integrate with image sync state machine #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 13, 2016 16:02
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd ImageCtx's cannot be deleted from within the librbd thread. This state machine will perform the deletion from the rbd-mirror work queue thread. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This state machine will open a local image and request the exclusive lock. If the open or lock fails, it will automatically close the image. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This state machine will handle the simple cases of creating a local image from a remote image, registering to the remote journal, and sync'ing the image contents. There are several TODOs for future remaining work. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
These should be reimplemented using google mock instead of virtual functions. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
jdurgin
added a commit
that referenced
this pull request
Mar 15, 2016
rbd-mirror: integrate with image sync state machine Reviewed-by: Josh Durgin <jdurgin@redhat.com>
|
nice decomposition of sync into small state machines - makes it much easier to read. merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.