Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: min_write_recency_for_promote & min_read_recency_for_promote are… #8081

Merged
merged 1 commit into from Mar 15, 2016
Merged

osd: min_write_recency_for_promote & min_read_recency_for_promote are… #8081

merged 1 commit into from Mar 15, 2016

Conversation

renhwztetecs
Copy link
Contributor

… only used in cache pool

min_write_recency_for_promote & min_read_recency_for_promote are only used in cache pool

@xiexingguo
Copy link
Member

Does not compile:

mon/OSDMonitor.cc: In member function ‘int OSDMonitor::prepare_command_pool_set(std::map<std::basic_string<char>, boost::variant<std::basic_string<char>, bool, long int, double, std::vector<std::basic_string<char> > > >&, std::stringstream&)’:
mon/OSDMonitor.cc:4924:49: error: ‘car’ was not declared in this scope
        var == "min_read_recency_for_promote" || car == "min_write_recency_for_promote")) {

xiexingguo
xiexingguo reviewed Mar 14, 2016
View reviewed changes
src/mon/OSDMonitor.cc
@@ -4829,7 +4829,8 @@ int OSDMonitor::prepare_command_pool_set(map<string,cmd_vartype> &cmdmap,
var == "cache_target_full_ratio" || var == "cache_target_dirty_ratio" ||
var == "cache_target_dirty_high_ratio" ||
var == "cache_min_flush_age" || var == "cache_min_evict_age" ||
var == "hit_set_grade_decay_rate" || var == "hit_set_search_last_n")) {
var == "hit_set_grade_decay_rate" || var == "hit_set_search_last_n" ||
var == "min_read_recency_for_promote" || car == "min_write_recency_for_promote")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, car-> var

@renhwztetecs
osd: min_write_recency_for_promote & min_read_recency_for_promote are…
0dbcb41 
… only used in cache pool

min_write_recency_for_promote & min_read_recency_for_promote are only used in cache pool

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
@liewegas liewegas added this to the jewel milestone Mar 14, 2016
liewegas added a commit that referenced this pull request Mar 15, 2016
@liewegas
Merge pull request #8081 from renhwsky/renhw-wip-osdmonitor-poolset
1cef679 
osd: min_write_recency_for_promote & min_read_recency_for_promote are tiering only

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit 1cef679 into ceph:master Mar 15, 2016
@renhwztetecs renhwztetecs deleted the renhw-wip-osdmonitor-poolset branch March 16, 2016 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix core needs-qa wip-sage-testing
Projects
None yet
Milestone
jewel
3 participants
@renhwztetecs @xiexingguo @liewegas