Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixup and improvements for rbd-mirror test #8090

Merged
merged 1 commit into from Mar 15, 2016

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Mar 14, 2016

Signed-off-by: Mykola Golub mgolub@mirantis.com

@trociny
Copy link
Contributor Author

trociny commented Mar 14, 2016

To troubleshoot a test failure I use the following commands:

From src dir start the test in NOCLEANUP mode (so it possible to check its state after failure) and with TEMPDIR pointing to known location):

RBD_MIRROR_NOCLEANUP=1 RBD_MIRROR_TEMDIR=/tmp/tmp.rbd_mirror ../qa/workunits/rbd/rbd_mirror.sh

After failure cd to TEMPDIR and check status:

cd /tmp/tmp.rbd_mirror
less rbd-mirror.log
rbd --cluster remote -p mirror journal status --image test
ceph --admin-daemon rbd-mirror.asok help
...

Run cleanup:

cd - #SRCDIR
RBD_MIRROR_TEMDIR=/tmp/tmp.rbd_mirror ../qa/workunits/rbd/rbd_mirror.sh cleanup

@jdurgin
Copy link
Member

jdurgin commented Mar 14, 2016

Could you add that comment on how to use it to the script (perhaps a comment on using the script at the top of the file)?

wait_for_image_replay_state ${image} started
}

wait_for_image_replay_stopped()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this isn't used yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was going to use this to test live image replayer removal after an image is removed (journaling is disabled). But right now I can't remove the image when it is replayed due to "Device or resource busy" error. Still I think it is desirable feature and we will be able to do this in some future, and this function will be useful then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to leave it in then. I think Jason fixed that EBUSY error with his aio_notify patch that's now in master.

Signed-off-by: Mykola Golub <mgolub@mirantis.com>
@trociny
Copy link
Contributor Author

trociny commented Mar 15, 2016

Rebased after adding "how to use" into the scrip.

jdurgin added a commit that referenced this pull request Mar 15, 2016
test: fixup and improvements for rbd-mirror test

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
@jdurgin jdurgin merged commit 129d83b into ceph:master Mar 15, 2016
@trociny trociny deleted the fixup-rbd-mirror-test branch March 21, 2016 08:49
Matan-B added a commit to Matan-B/ceph that referenced this pull request Sep 29, 2022
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan-B added a commit to Matan-B/ceph that referenced this pull request Sep 29, 2022
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
ljflores pushed a commit to ljflores/ceph that referenced this pull request Nov 17, 2022
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants