New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fixup and improvements for rbd-mirror test #8090
Conversation
To troubleshoot a test failure I use the following commands: From src dir start the test in NOCLEANUP mode (so it possible to check its state after failure) and with TEMPDIR pointing to known location):
After failure cd to TEMPDIR and check status:
Run cleanup:
|
Could you add that comment on how to use it to the script (perhaps a comment on using the script at the top of the file)? |
wait_for_image_replay_state ${image} started | ||
} | ||
|
||
wait_for_image_replay_stopped() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this isn't used yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was going to use this to test live image replayer removal after an image is removed (journaling is disabled). But right now I can't remove the image when it is replayed due to "Device or resource busy" error. Still I think it is desirable feature and we will be able to do this in some future, and this function will be useful then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to leave it in then. I think Jason fixed that EBUSY error with his aio_notify patch that's now in master.
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
c8887e8
to
8e41220
Compare
Rebased after adding "how to use" into the scrip. |
test: fixup and improvements for rbd-mirror test Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Mykola Golub mgolub@mirantis.com