osd: ensure new osdmaps commit before publishing them to pgs #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
|
LGTM! |
|
lgtm |
handle_osd_map and the PGs use different sequencers when writing their updates. We therefore need to make sure new osdmaps are committed to disk before we expose them to PGs, lest they update their info to reference a new osdmap that hasn't actually committed yet. This doesn't happen with FileStore because transactions are ordered when they are queued, but it does affect BlueStore. Fix by splitting handle_osd_map into two phases, one that just persists stuff, and the second half that publishes the new maps to the rest of the OSD. Fixes: ceph#15073 Signed-off-by: Sage Weil <sage@redhat.com>
handle_osd_map now adds OSDMaps to the cache as it receives them but before they are stable. Ensure that we don't try to use them. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added a commit
that referenced
this pull request
Mar 17, 2016
osd: ensure new osdmaps commit before publishing them to pgs Reviewed-by: Samuel Just <sjust@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.