Jewel cephfs data scan misc #8115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directory inode's size should be always zero. Signed-off-by: Yan, Zheng <zyan@redhat.com>
ukernel
force-pushed
the
jewel-cephfs-data-scan-misc
branch
2 times, most recently
from
887c751
to
caf1d7f
Compare
| @@ -147,7 +147,8 @@ class MetadataTool | |||
| * Construct a synthetic InodeStore for a normal file | |||
| */ | |||
| void build_file_dentry( | |||
| inodeno_t ino, uint64_t file_size, time_t file_mtime, | |||
| inodeno_t ino, uint64_t nfiles, | |||
There was a problem hiding this comment.
Maybe this is a typo? It doesn't make sense to call file_size nfiles here, because this is the function for creating normal file dentries, not directories.
|
👍 apart from one minor comment (+ I checked that this passes TestDataScan locally) |
so that the directory doesn't appear to be empty Signed-off-by: Yan, Zheng <zyan@redhat.com>
ukernel
force-pushed
the
jewel-cephfs-data-scan-misc
branch
from
caf1d7f
to
cd14bcc
Compare
|
Sorry, it's typo. I removed it. |
gregsfortytwo
added a commit
that referenced
this pull request
Mar 18, 2016
…l/ceph into greg-fs-testing #8115
gregsfortytwo
added a commit
that referenced
this pull request
Mar 24, 2016
…l/ceph into greg-fs-testing #8115
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.